Skip to content

auth: Add more SQL schema files to packages and tarballs #8776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 15, 2020

Conversation

mnordhoff
Copy link
Contributor

@mnordhoff mnordhoff commented Feb 2, 2020

Short description

  • Add the 4.3.0 SQL schema upgrade files to tarballs. (I think.)
  • Add the 3.4.0 through 4.3.0 files to the packages!
  • Add the bind files to the pdns (rpm) and pdns-backend-bind (deb) packages.
  • Add enable-foreign-keys.mysql.sql to the package and tarballs. (Don't know if it's useful, but it's not not useful.)
  • Also reformat godbc's Makefile.am similar to how the other backends were done. (And switch the order of a .cc file and a .hh file; I think it's an unordered list?)

The tarball issue was reported by HellSpawn the other day.

I've tested building CentOS 8, Debian Buster and Ubuntu Bionic with pdns-builder, and listed the contents of the debs and rpms and tarballs produced, but I haven't done any further testing (like actually installing things).

I duplicated SQL files between EXTRA_DIST and dist_doc_DATA, which was probably unnecessary.

I don't know if there are additional steps beyond "create pdns-backend-bind.docs", but that's what I did and it worked...

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@Habbie Habbie added this to the auth-4.3.0-beta2 milestone Feb 2, 2020
@Habbie Habbie requested a review from pieterlexis February 2, 2020 22:21
@pieterlexis
Copy link
Contributor

I duplicated SQL files between EXTRA_DIST and dist_doc_DATA, which was probably unnecessary.

That is the case :)

Copy link
Contributor

@pieterlexis pieterlexis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, apart from the "I duplicated SQL files between EXTRA_DIST and dist_doc_DATA, which was probably unnecessary." comment

@mnordhoff
Copy link
Contributor Author

Deduplicated (but this commit is totally untested)

@Habbie
Copy link
Member

Habbie commented Feb 14, 2020

@mnordhoff
Copy link
Contributor Author

The CentOS 8 build failed because this branch doesn't have #8807. >_<

@Habbie
Copy link
Member

Habbie commented Feb 14, 2020

The CentOS 8 build failed because this branch doesn't have #8807

Ugh! Can you rebase?

@mnordhoff
Copy link
Contributor Author

Ugh! Can you rebase?

Done. Dunno if it works, though!

@Habbie
Copy link
Member

Habbie commented Feb 14, 2020

Done. Dunno if it works, though!

http://builder.powerdns.com/#/buildrequests/123604?redirect_to_build=true

@Habbie
Copy link
Member

Habbie commented Feb 15, 2020

  • the tarball contains all .sql files (except one that is part of a test, this is fine)
  • .sql content is consistent between el6/7/8, with the interesting note that the files move from (example) /usr/share/doc/pdns-backend-postgresql-4.3.0/3.4.0_to_4.1.0_schema.pgsql.sql in el7 to /usr/share/doc/pdns-backend-postgresql/3.4.0_to_4.1.0_schema.pgsql.sql in el8. Of course, that has nothing to do with this PR.
  • centos packages appear to be complete
  • .sql content is consistent between debian stretch and buster
  • debian packages appear to be lacking 3.4.0_to_4.0.0_schema.sqlite3.sql

@Habbie
Copy link
Member

Habbie commented Feb 15, 2020

debian packages appear to be lacking 3.4.0_to_4.0.0_schema.sqlite3.sql

CORRECTION: /usr/share/doc/pdns-backend-sqlite3/3.4.0_to_4.0.0_schema.sqlite3.sql.gz | unchanged

@Habbie Habbie merged commit 2d3bb03 into PowerDNS:master Feb 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants