-
Notifications
You must be signed in to change notification settings - Fork 923
auth: Add more SQL schema files to packages and tarballs #8776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
That is the case :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, apart from the "I duplicated SQL files between EXTRA_DIST and dist_doc_DATA, which was probably unnecessary." comment
Deduplicated (but this commit is totally untested) |
The CentOS 8 build failed because this branch doesn't have #8807. >_< |
Ugh! Can you rebase? |
And clean up godbcbackend's Makefile.am.
f103560
to
9527e8a
Compare
Done. Dunno if it works, though! |
http://builder.powerdns.com/#/buildrequests/123604?redirect_to_build=true |
|
CORRECTION: |
Short description
bind
files to thepdns
(rpm) andpdns-backend-bind
(deb) packages.enable-foreign-keys.mysql.sql
to the package and tarballs. (Don't know if it's useful, but it's not not useful.)godbc
'sMakefile.am
similar to how the other backends were done. (And switch the order of a.cc
file and a.hh
file; I think it's an unordered list?)The tarball issue was reported by HellSpawn the other day.
I've tested building CentOS 8, Debian Buster and Ubuntu Bionic with pdns-builder, and listed the contents of the debs and rpms and tarballs produced, but I haven't done any further testing (like actually installing things).
I duplicated SQL files between
EXTRA_DIST
anddist_doc_DATA
, which was probably unnecessary.I don't know if there are additional steps beyond "create
pdns-backend-bind.docs
", but that's what I did and it worked...Checklist
I have: