Update user home event when createhome is set to False #30125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed cretehome from if statement since home should be updated even when createhome is set to False. Fixes saltstack#29633.
|
This was introduced by @twangboy here: #28932 We need to make sure we handle both use-cases here. @twangboy could you please hop in here and work with @abednarik and @twellspring to sort this out? Thanks. |
cachedout
added
the
Pending-Discussion
|
@abednarik @twellspring @cachedout I think this change is fine. I don't remember my thinking when I changed that. |
|
Thanks for the update. I'm open to review or work on anything that you guys think that there is something else to do here. Cheers |
cachedout
pushed a commit
that referenced
this pull request
Jan 5, 2016
Update user home event when createhome is set to False
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed cretehome from if statement since home should be updated even when createhome is set
to False.
Fixes #29633.