Skip to content

USWDS-Site: Replace outdated copySetup references with copyTheme #2071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 11, 2023
Merged

USWDS-Site: Replace outdated copySetup references with copyTheme #2071

merged 3 commits into from
May 11, 2023

Conversation

amyleadem
Copy link
Contributor

@amyleadem amyleadem commented Apr 27, 2023 •
edited
Loading

Summary

Replaced copySetup references with copyTheme.

Related issue

Closes #2070

Preview link

Preview link: Phase 2 - Compile page

Problem statement

The Phase 2 Compile guide lists the copySetup gulp task, but it is now called copyTheme in uswds-compile.

Link to copyTheme in uswds-compile's gulpfile.js: http://github.com/uswds/uswds-compile/blob/develop/gulpfile.js#L261

Solution

Replaced all copySetup references with copyTheme

Testing and review

  1. Confirm that copyTheme is the correct name of the gulp task
  2. Confirm that all copySetup references have been updated

@amyleadem amyleadem marked this pull request as ready for review April 28, 2023 00:02
@amyleadem amyleadem requested review from mahoneycm and mejiaj April 28, 2023 00:02
mahoneycm
mahoneycm approved these changes Apr 28, 2023
View reviewed changes
Copy link
Contributor

@mahoneycm mahoneycm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this!

  • Confirmed copySetup task in gulp has been updated to copyTheme
  • Confirmed the update on site reflects this change in the gulp tasks name
  • Confirmed there are no other references to copySetup on site

@mejiaj mejiaj merged commit 1d012c1 into main May 11, 2023
@mejiaj mejiaj deleted the al-fix-copySetup branch May 11, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mejiaj mejiaj mejiaj approved these changes

@mahoneycm mahoneycm mahoneycm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

USWDS-Site: Update name for copySetup gulp task
3 participants
@amyleadem @mejiaj @mahoneycm