Skip to content

USWDS-Site - Implementations: Add MetroStar Comet to USWDS implementations #2152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 11, 2023

Conversation

jbouder
Copy link

@jbouder jbouder commented Jun 26, 2023

Summary

  • Added MetroStar Comet Component Library to USWDS Implementations list

Related issue

Closes #2146

@mejiaj mejiaj requested review from mejiaj, mahoneycm and amyleadem June 26, 2023 17:26
Copy link
Contributor

@amyleadem amyleadem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jboulder Thanks for submitting this PR! I have added a comment with some suggestions to add clarity to the notes. Will you take a look and confirm that everything still makes sense?

Additionally, would you be able to update the implementations changelog file with a changelog entry so that users will know when this was added? The data items should follow the same structure as previous entries in that file, but with info specific to this PR. Please reach out if you have any questions or would prefer that we create that entry for you.

name: MetroStar
url: http://github.com/MetroStar
version: 3.5.0
notes: "React with TypeScript implementation of USWDS, providing additional modular support for custom components, data visualization, and command line tools. Sample starter app included that is focused on accelerating and scaling design across the enterprise."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a couple of suggestions to help improve clarity.

Suggested change
notes: "React with TypeScript implementation of USWDS, providing additional modular support for custom components, data visualization, and command line tools. Sample starter app included that is focused on accelerating and scaling design across the enterprise."
notes: "A React with TypeScript component library based on USWDS 3.0. This library provides modular support for custom components, data visualization, and command line tools. Comet also includes a sample starter app that is focused on accelerating and scaling design across the enterprise."

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated as requested. Thank you!

Copy link
Contributor

@mejiaj mejiaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but requires a new changelog item in changelogs/docs-implementations.yml.

Example

  - date: 2023-06-27
    summary: Added entry for MetroStar Comet implementation.
    affectsGuidance: true
    githubPr: 2152
    githubRepo: uswds-site

@jbouder jbouder requested review from mejiaj and amyleadem June 27, 2023 17:04
@jbouder
Copy link
Author

jbouder commented Jun 30, 2023

@mejiaj @amyleadem , just wanted to see if there were any updates on this. All should be good to go.

Copy link
Contributor

@amyleadem amyleadem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good! Added a note to the team that we should update the changelog date before merge.

@@ -2,6 +2,18 @@ title: Implementations
type: documentation
changelogURL:
items:
- date: 2023-06-27
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note
We should update the date right before merge.

Copy link
Contributor

@mahoneycm mahoneycm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! And the component previews are looking great on the newest version of Storybook! 👍

Copy link
Contributor

@mejiaj mejiaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, created this internal PR #2167 to make final changes before merge.

@jbouder
Copy link
Author

jbouder commented Jul 11, 2023

Thanks! Let me know if there is anything more I need to do.

@thisisdano thisisdano merged commit 6a138ce into uswds:main Jul 11, 2023
@mejiaj
Copy link
Contributor

mejiaj commented Jul 11, 2023

@jbouder it's live, thanks for your contribution!

@jbouder
Copy link
Author

jbouder commented Jul 11, 2023

@mejiaj , thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new React Metrostar Implementation to Implementations page
5 participants