-
Notifications
You must be signed in to change notification settings - Fork 194
USWDS-Site - Implementations: Add MetroStar Comet to USWDS implementations #2152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jboulder Thanks for submitting this PR! I have added a comment with some suggestions to add clarity to the notes. Will you take a look and confirm that everything still makes sense?
Additionally, would you be able to update the implementations changelog file with a changelog entry so that users will know when this was added? The data items should follow the same structure as previous entries in that file, but with info specific to this PR. Please reach out if you have any questions or would prefer that we create that entry for you.
_data/implementations.yml
Outdated
name: MetroStar | ||
url: http://github.com/MetroStar | ||
version: 3.5.0 | ||
notes: "React with TypeScript implementation of USWDS, providing additional modular support for custom components, data visualization, and command line tools. Sample starter app included that is focused on accelerating and scaling design across the enterprise." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a couple of suggestions to help improve clarity.
notes: "React with TypeScript implementation of USWDS, providing additional modular support for custom components, data visualization, and command line tools. Sample starter app included that is focused on accelerating and scaling design across the enterprise." | |
notes: "A React with TypeScript component library based on USWDS 3.0. This library provides modular support for custom components, data visualization, and command line tools. Comet also includes a sample starter app that is focused on accelerating and scaling design across the enterprise." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated as requested. Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but requires a new changelog item in changelogs/docs-implementations.yml.
Example
- date: 2023-06-27
summary: Added entry for MetroStar Comet implementation.
affectsGuidance: true
githubPr: 2152
githubRepo: uswds-site
@mejiaj @amyleadem , just wanted to see if there were any updates on this. All should be good to go. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good! Added a note to the team that we should update the changelog date before merge.
@@ -2,6 +2,18 @@ title: Implementations | |||
type: documentation | |||
changelogURL: | |||
items: | |||
- date: 2023-06-27 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note
We should update the date right before merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! And the component previews are looking great on the newest version of Storybook! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, created this internal PR #2167 to make final changes before merge.
Thanks! Let me know if there is anything more I need to do. |
@jbouder it's live, thanks for your contribution! |
@mejiaj , thank you so much! |
Summary
Related issue
Closes #2146